-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure rm changes #32
base: master
Are you sure you want to change the base?
Azure rm changes #32
Conversation
allowed_certificate_thumbprints = local.thumbprints_in_quotes_str | ||
s2s_client_id = data.azurerm_key_vault_secret.s2s_client_id.value | ||
s2s_client_secret = data.azurerm_key_vault_secret.s2s_client_secret.value | ||
s2s_base_url = local.s2sUrl | ||
} | ||
} | ||
|
||
data "template_file" "api_template" { | ||
template = "${file("${path.module}/template/api.json")}" | ||
} | ||
resource "azurerm_template_deployment" "api" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be using one of our terraform modules for api management not an arm template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this causes the resource to be deleted, we cannot make this change.
@@ -0,0 +1,17 @@ | |||
terraform { | |||
backend "azurerm" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what adds saving the state to azure, if it's not here then the state won't get saved to azure ever.
note that the state file is keyed by the 'product' var in your Jenkinsfile so you might want to change it to be more specific to your repo:
https://github.com/hmcts/ccpay-payment-api-gateway/blob/master/Jenkinsfile_CNP#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the state config never existed before. But the last time the pipeline executed successfully on 12/10/2020, it was pointing at the state file in question now.
Will discuss with project team to change the product name. However, we need to import the existing resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the Jenkins file with new name.
Plan Result
|
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")